lkml.org 
[lkml]   [2010]   [Jul]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [Intel-gfx] [PATCH] drm/i915: Selectively enable self-reclaim
    From
    On Wed, 30 Jun 2010 18:24:04 -0700, Linus Torvalds <torvalds@linux-foundation.org> wrote:
    > On Wed, Jun 30, 2010 at 4:07 PM, Linus Torvalds
    > <torvalds@linux-foundation.org> wrote:
    > >
    > > That commit changes the page cache allocation to use
    > >
    > > +                                          mapping_gfp_mask (mapping) |
    > > +                                          __GFP_COLD |
    > > +                                          gfpmask);
    > >
    > > if I read it right. And the default mapping_gfp_mask() is
    > > GFP_HIGHUSER_MOVABLE, so I think you get all of
    > > (__GFP_WAIT | __GFP_IO | __GFP_FS | __GFP_HARDWALL | __GFP_HIGHMEM)
    > > set by default.
    >
    > .. and then I left out the one flag I _meant_ to have there, namely
    > __GFP_MOVABLE.
    >
    > > The old code didn't just play games with ~__GFP_NORETRY and change
    > > that at runtime (which was buggy - no locking, no protection, no
    > > nothing), it also initialized the gfp mask. And that code also got
    > > removed:

    That code I added with the original shrinker patch, and the flags lifted
    from the shmem defaults, tweaked to what seemed sane with the addition of
    NORETRY and friends. I see that i915 is unique in using shmem as the page
    allocator, which perhaps explains why this failure is not observed with
    the ttm drivers. ttm uses two sets of gfp mask: HIGHUSER and USER | DMA32.
    So replacing the mapping_gfp_mask() with HIGHUSER would seem appropriate.
    And the interaction of MOVABLE could explain why hibernate broke with the
    introduction of GEM.

    * turns to his trusty copy of LDD to explain the various meanings of
    gfp_t...
    --
    Chris Wilson, Intel Open Source Technology Centre
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2010-07-01 13:21    [W:0.021 / U:30.104 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site