lkml.org 
[lkml]   [2010]   [Jul]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[166/200] nfsd: nfsd_setattr needs to call commit_metadata
    2.6.34-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Christoph Hellwig <hch@lst.de>

    commit b160fdabe93a8a53094f90f02bf4dcb500782aab upstream.

    The conversion of write_inode_now calls to commit_metadata in commit
    f501912a35c02eadc55ca9396ece55fe36f785d0 missed out the call in nfsd_setattr.

    But without this conversion we can't guarantee that a SETATTR request
    has actually been commited to disk with XFS, which causes a regression
    from 2.6.32 (only for NFSv2, but anyway).

    Signed-off-by: Christoph Hellwig <hch@lst.de>
    Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    fs/nfsd/vfs.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    --- a/fs/nfsd/vfs.c
    +++ b/fs/nfsd/vfs.c
    @@ -443,8 +443,7 @@ nfsd_setattr(struct svc_rqst *rqstp, str
    if (size_change)
    put_write_access(inode);
    if (!err)
    - if (EX_ISSYNC(fhp->fh_export))
    - write_inode_now(inode, 1);
    + commit_metadata(fhp);
    out:
    return err;




    \
     
     \ /
      Last update: 2010-07-01 23:21    [W:4.806 / U:0.256 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site