lkml.org 
[lkml]   [2010]   [Jul]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[patch 111/164] sata_nv: dont diddle with nIEN on mcp55
    2.6.33-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Tejun Heo <tj@kernel.org>

    commit f3faf8fc3fab45c3526efe8c9e99bb23f8723350 upstream.

    On mcp55, nIEN gets stuck once set and liteon blueray rom iHOS104-08
    violates ATA specification and fails to set I on D2H Reg FIS if nIEN
    is set when the command was issued. When the other party is following
    the spec, both devices can work fine but when the two flaws are put
    together, they can't talk to each other.

    mcp55 has its own IRQ masking mechanism and there's no reason to mess
    with nIEN in the first place. Fix it by dropping nIEN diddling from
    nv_mcp55_freeze/thaw().

    This was originally reported by Cengiz. Although Cengiz hasn't
    verified the fix yet, I could reproduce this problem and verfiy the
    fix. Even if Cengiz is experiencing different or additional problems,
    this patch is needed.

    Signed-off-by: Tejun Heo <tj@kernel.org>
    Reported-by: Cengiz Günay <cgunay@emory.edu>
    Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    drivers/ata/sata_nv.c | 2 --
    1 file changed, 2 deletions(-)

    --- a/drivers/ata/sata_nv.c
    +++ b/drivers/ata/sata_nv.c
    @@ -1673,7 +1673,6 @@ static void nv_mcp55_freeze(struct ata_p
    mask = readl(mmio_base + NV_INT_ENABLE_MCP55);
    mask &= ~(NV_INT_ALL_MCP55 << shift);
    writel(mask, mmio_base + NV_INT_ENABLE_MCP55);
    - ata_sff_freeze(ap);
    }

    static void nv_mcp55_thaw(struct ata_port *ap)
    @@ -1687,7 +1686,6 @@ static void nv_mcp55_thaw(struct ata_por
    mask = readl(mmio_base + NV_INT_ENABLE_MCP55);
    mask |= (NV_INT_MASK_MCP55 << shift);
    writel(mask, mmio_base + NV_INT_ENABLE_MCP55);
    - ata_sff_thaw(ap);
    }

    static void nv_adma_error_handler(struct ata_port *ap)

    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2010-07-01 22:59    [W:3.169 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site