Messages in this thread | | | Date | Tue, 8 Jun 2010 09:01:20 +0100 | From | Alan Cox <> | Subject | Re: [PATCH] Topcliff PHUB: Generate PacketHub driver |
| |
On Tue, 8 Jun 2010 14:46:31 +0900 "Masayuki Ohtake" <masa-korg@dsn.okisemi.com> wrote:
> Hi Alan > > > > Remember here ioctl isn't single threaded so you may want to double check > > > > > some of these > > > > The above copy_from_user is Copy global variable to local variable. > > Thus, We think this code has re-entrant. > The above is not true. > Our ioctl routine is just used under single pthread.
What if someone else chooses to open it and run multiple threads through it. What if the code changes. What about malicious attempts to confuse the driver ?
The fact your own current userspace does not do this does not mean it can be ignored.
Alan
| |