Messages in this thread | | | Date | Tue, 08 Jun 2010 10:52:02 +0300 | From | Boaz Harrosh <> | Subject | Re: [PATCH, v2] kbuild: Improve version string logic - two for the price of one - No thanks |
| |
On 06/08/2010 10:32 AM, Paul Mundt wrote: > On Tue, Jun 08, 2010 at 10:21:54AM +0300, Boaz Harrosh wrote: >> On 06/08/2010 10:16 AM, Boaz Harrosh wrote: >> OK I get it above should be: >> [my-tree] $ echo "-my_tree" > localversion-my_tree >> >> But now I get DEPMOD 2.6.35-rc2-my_tree+ >> >> Please fix it so if localversion* is present then the plus is >> removed. And the git is not inspected >> > How is that a 'fix'? If I'm using localversion* and have people sending > me bug reports, I still do want to see the git ID. The + thing in this > context might not have any meaning since the 2.6.35-rc2 that you've > tagged for your tree and the release one could wildly differ, but that's > more of an argument against the + thing existing at all than anything > else. >
You lost me sorry. I don't understand what you are saying ?
> Whether having LOCALVERSION_AUTO be compulsory is a good idea or not is > another matter entirely, the localversion* semantics are pretty > clear-cut.
the "localversion* semantics" is not the issue here. The issue is the CONFIG_LOCALVERSION_AUTO semantics. You have effectively made it compulsory but with a choice of a style. "From the frying pan to the fire"
And you have broken the "localversion* semantics". Because my vanilla release is 2.6.rc2-my_tree-my_ver as checkedout and delivered from my official tree. Now you have added a "+" regardless of if it is an official tagged version or not.
I do not expect a complicated "let me be smarter than you" system that checks any tags of mine and provides an out-of-tree version system. I just want a switch that tells the system. "Let me shoot myself in the leg, I know what I want"
"localversion*" should override any automatism as an indication of an alternative tagging system. (Or any other switch that can turn this off)
And please stop the politics: "having LOCALVERSION_AUTO be compulsory" is Politics not, anything technical: "how to support my needs"
Boaz
| |