lkml.org 
[lkml]   [2010]   [Jun]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH, v2] kbuild: Improve version string logic - two for the price of one - No thanks
    On Tue, Jun 08, 2010 at 10:16:39AM +0300, Boaz Harrosh wrote:
    > On 06/08/2010 09:39 AM, Boaz Harrosh wrote:
    > > On 06/08/2010 09:34 AM, Paul Mundt wrote:
    > >> On Mon, Jun 07, 2010 at 11:18:42PM -0700, David Rientjes wrote:
    > >>> On Tue, 8 Jun 2010, Boaz Harrosh wrote:
    > >>>
    > >>>>>> I already have my:
    > >>>>>> VERSION = 2
    > >>>>>> PATCHLEVEL = 6
    > >>>>>> SUBLEVEL = 35
    > >>>>>> -EXTRAVERSION = -rc2
    > >>>>>> +EXTRAVERSION = -rc2-my_tree
    > >>>>>>
    > >>>>>
    > >>>>> You shouldn't be using EXTRAVERSION for this purpose, you should be
    > >>>>> passing LOCALVERSION=my_tree to make.
    > >>>>>
    > >>>>
    > >>>> That will not work because the way I run make is out of my control. Every
    > >>>> one in the working group has his system. The Makefile is part of the
    > >>>> public git tree, so every one will get the same identification without
    > >>>> any confusion with Vanilla kernel, or what was compiled.
    > >>>>
    > >>>
    > >>> If everyone using that tree wants the same version string for that kernel,
    > >>> use CONFIG_LOCALVERSION="-my_tree" in your .config and use "make
    > >>> LOCALVERSION=".
    > >>>
    > >> Or just distribute a localversion-my_tree file in the top-level directory
    > >> like other trees do. This doesn't strike me as a particularly significant
    > >> problem.
    > >
    >
    >
    > I can't manage to work this out. Here is what I did please, what did I do wrong:
    > [my-tree] $ git checkout v2.6.35-rc2
    > [my-tree] $ touch localversion-my_tree

    It's not frightfully intuitive, you have to have the string in the file.
    So simply doing:

    $ echo "-my_tree" > localversion-my_tree

    ought to work fine for your case.


    \
     
     \ /
      Last update: 2010-06-08 09:23    [W:0.025 / U:0.516 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site