Messages in this thread | | | Date | Mon, 7 Jun 2010 21:44:51 -0700 (PDT) | From | David Rientjes <> | Subject | Re: [PATCH 01/12] arch/cris: Remove unnecessary kmalloc casts |
| |
On Mon, 7 Jun 2010, Joe Perches wrote:
> And separate declaration from allocation > Still no error checking on failure, but it probably doesn't matter. > > Signed-off-by: Joe Perches <joe@perches.com> > --- > arch/cris/arch-v32/mm/intmem.c | 13 +++++-------- > 1 files changed, 5 insertions(+), 8 deletions(-) > > diff --git a/arch/cris/arch-v32/mm/intmem.c b/arch/cris/arch-v32/mm/intmem.c > index 9e8b69c..1b17d92 100644 > --- a/arch/cris/arch-v32/mm/intmem.c > +++ b/arch/cris/arch-v32/mm/intmem.c > @@ -33,8 +33,8 @@ static void crisv32_intmem_init(void) > { > static int initiated = 0; > if (!initiated) { > - struct intmem_allocation* alloc = > - (struct intmem_allocation*)kmalloc(sizeof *alloc, GFP_KERNEL); > + struct intmem_allocation* alloc; > + alloc = kmalloc(sizeof *alloc, GFP_KERNEL); > INIT_LIST_HEAD(&intmem_allocations); > intmem_virtual = ioremap(MEM_INTMEM_START + RESERVED_SIZE, > MEM_INTMEM_SIZE - RESERVED_SIZE); > @@ -62,9 +62,8 @@ void* crisv32_intmem_alloc(unsigned size, unsigned align) > if (allocation->status == STATUS_FREE && > allocation->size >= size + alignment) { > if (allocation->size > size + alignment) { > - struct intmem_allocation* alloc = > - (struct intmem_allocation*) > - kmalloc(sizeof *alloc, GFP_ATOMIC); > + struct intmem_allocation* alloc; > + alloc = kmalloc(sizeof *alloc, GFP_ATOMIC); > alloc->status = STATUS_FREE; > alloc->size = allocation->size - size - > alignment;
Why not fix the checkpatch failures at the same time?
ERROR: "foo* bar" should be "foo *bar" #26: FILE: arch/cris/arch-v32/mm/intmem.c:36: + struct intmem_allocation* alloc;
ERROR: "foo* bar" should be "foo *bar" #38: FILE: arch/cris/arch-v32/mm/intmem.c:65: + struct intmem_allocation* alloc;
| |