Messages in this thread |  | | | Date | Mon, 7 Jun 2010 07:53:59 +0300 | | From | Baruch Siach <> | | Subject | Re: [rtc-linux] [PATCH] rtc: driver for the DryIce block found in i.MX25 chips |
| |
Hi Wan,
On Sat, Jun 05, 2010 at 11:08:46PM +0800, Wan ZongShun wrote: > Some minor comments below:
Thank you very much for you review and comments. I'll address your comments (and Andrew's), and send an update shortly.
> Are local_irq_disable() and al_irq_enable() necessary? > > RTC ‘rtc_update_irq’ seem to have called 'spin_lock_irqsave' , where > local irq will be disable.
You're right. Since commit e6229bec25be4ba00f31dd26e25721cc96c22262 rtc_update_irq can be called with irqs enabled.
baruch
-- ~. .~ Tk Open Systems =}------------------------------------------------ooO--U--Ooo------------{= - baruch@tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il - -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |