lkml.org 
[lkml]   [2010]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] Support kernel/hotplug sysctl variable when !CONFIG_NET
    On Mon, 7 Jun 2010 10:43:50 -0700 Greg KH wrote:

    > On Mon, Jun 07, 2010 at 12:57:12PM +0100, Ian Abbott wrote:
    > > From: Ian Abbott <abbotti@mev.co.uk>
    > >
    > > The kernel/hotplug sysctl variable (/proc/sys/kernel/hotplug file) was
    > > made conditional on CONFIG_NET by commit
    > > f743ca5e10f4145e0b3e6d11b9b46171e16af7ce (applied in 2.6.18) to fix
    > > problems with undefined references in 2.6.16 when CONFIG_HOTPLUG=y &&
    > > !CONFIG_NET, but this restriction is no longer needed.

    Ack, builds for me on x86_64 when CONFIG_NET is not enabled.

    > Why is this restriction no longer needed? What changed?


    commit cd3772e6898c6386f21d2958346d6dd57d4204f5
    Author: Ming Lei <tom.leiming@gmail.com>
    Date: Sun Nov 16 18:22:09 2008 +0800

    kernel/ksysfs.c:fix dependence on CONFIG_NET

    Access to uevent_seqnum and uevent_helper does not need to
    depend on CONFIG_NET, so remove it.

    Signed-off-by: Ming Lei <tom.leiming@gmail.com>
    Cc: Kay Sievers <kay.sievers@vrfy.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>


    > > This patch makes the kernel/hotplug sysctl variable depend only on
    > > CONFIG_HOTPLUG.
    >
    > Why is this needed? Are you really running without a network and still
    > want to change the default /sbin/hotplug binary?
    >
    > confused,


    ---
    ~Randy
    *** Remember to use Documentation/SubmitChecklist when testing your code ***


    \
     
     \ /
      Last update: 2010-06-07 20:15    [W:0.028 / U:0.448 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site