lkml.org 
[lkml]   [2010]   [Jun]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [RFC][PATCH 5/6] Cleanup hrtimer.c's direct access to wall_to_monotonic
Fromjohn stultz <>
DateSat, 05 Jun 2010 11:01:45 -0700
On Sat, 2010-06-05 at 12:23 +0200, Arnd Bergmann wrote:
> On Saturday 05 June 2010, John Stultz wrote:
> > do {
> > seq = read_seqbegin(&xtime_lock);
> > xts = __current_kernel_time();
> > - tom = wall_to_monotonic;
> > + tom = __get_wall_to_monotonic();
> > } while (read_seqretry(&xtime_lock, seq));
> >
>
> Would it make sense to also limit the use of xtime_lock to the
> timekeeping code? I suppose you could merge the various accessors
> (current_kernel_time, get_monotonic_coarse, __current_kernel_time,
> __get_wall_to_monotonic) with a single function doing

Yep. I hope to keep chipping at it to get there.

However xtime_lock protects a bit more then just the timekeeping
internals, and its currently not limiting the rework I'm hoping to do
with the timekeeping internal structures. So little bits at a time. :)

thanks
-john






\
 
 \ /
  Last update: 2010-06-05 20:05    [from the cache]
©2003-2010