lkml.org 
[lkml]   [2010]   [Jun]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 08/11] tty: fix a little bug in scrup, vt.c
    Date
    From: Frank Pan <frankpzh@gmail.com>

    The code uses vc->vc_cols instead of vc->vc_size_row by mistake, it
    will cause half of the region which is going to clear remain
    uncleared.
    The issue happens in background consoles, so it's hard to observe.

    Frank Pan

    Signed-off-by: Frank Pan <frankpzh@gmail.com>
    Cc: stable <stable@kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    ---
    drivers/char/vt.c | 2 +-
    1 files changed, 1 insertions(+), 1 deletions(-)

    diff --git a/drivers/char/vt.c b/drivers/char/vt.c
    index 7cdb6ee..1296c42 100644
    --- a/drivers/char/vt.c
    +++ b/drivers/char/vt.c
    @@ -304,7 +304,7 @@ static void scrup(struct vc_data *vc, unsigned int t, unsigned int b, int nr)
    d = (unsigned short *)(vc->vc_origin + vc->vc_size_row * t);
    s = (unsigned short *)(vc->vc_origin + vc->vc_size_row * (t + nr));
    scr_memmovew(d, s, (b - t - nr) * vc->vc_size_row);
    - scr_memsetw(d + (b - t - nr) * vc->vc_cols, vc->vc_video_erase_char,
    + scr_memsetw(d + (b - t - nr) * vc->vc_size_row, vc->vc_video_erase_char,
    vc->vc_size_row * nr);
    }

    --
    1.7.1


    \
     
     \ /
      Last update: 2010-06-04 22:51    [W:0.020 / U:1.412 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site