lkml.org 
[lkml]   [2010]   [Jun]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 4/9] oom: oom_kill_process() need to check p is unkillable
Date
> On Mon, 21 Jun 2010, KOSAKI Motohiro wrote:
>
> > > > When oom_kill_allocating_task is enabled, an argument task of
> > > > oom_kill_process is not selected by select_bad_process(), It's
> > > > just out_of_memory() caller task. It mean the task can be
> > > > unkillable. check it first.
> > > >
> > >
> > > This should be unnecessary if oom_kill_process() appropriately returns
> > > non-zero when it cannot kill a task. What problem are you addressing with
> > > this fix?
> >
> > oom_kill_process() only check its children are unkillable, not its own.
>
> No, oom_kill_process() returns the value of oom_kill_task(victim) which is
> non-zero for !victim->mm in mmotm-2010-06-11-16-40 (and 2.6.34 although
> victim == p in that case).

oom_kill_task() only check OOM_DISABLE. and Minchan elaborated more detailed
concern. please see his mail.




\
 
 \ /
  Last update: 2010-06-30 11:29    [W:0.048 / U:0.924 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site