lkml.org 
[lkml]   [2010]   [Jun]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 01/12] oom: select_bad_process: check PF_KTHREAD instead of !mm to skip kthreads
    Date
    From: Oleg Nesterov <oleg@redhat.com>

    select_bad_process() thinks a kernel thread can't have ->mm != NULL, this
    is not true due to use_mm().

    Change the code to check PF_KTHREAD.

    Signed-off-by: Oleg Nesterov <oleg@redhat.com>
    Acked-by: David Rientjes <rientjes@google.com>
    Reviewed-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
    Reviewed-by: Minchan Kim <minchan.kim@gmail.com>
    Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
    ---
    mm/oom_kill.c | 9 +++------
    1 files changed, 3 insertions(+), 6 deletions(-)

    diff --git a/mm/oom_kill.c b/mm/oom_kill.c
    index 709aedf..070b713 100644
    --- a/mm/oom_kill.c
    +++ b/mm/oom_kill.c
    @@ -256,14 +256,11 @@ static struct task_struct *select_bad_process(unsigned long *ppoints,
    for_each_process(p) {
    unsigned long points;

    - /*
    - * skip kernel threads and tasks which have already released
    - * their mm.
    - */
    + /* skip the tasks which have already released their mm. */
    if (!p->mm)
    continue;
    - /* skip the init task */
    - if (is_global_init(p))
    + /* skip the init task and kthreads */
    + if (is_global_init(p) || (p->flags & PF_KTHREAD))
    continue;
    if (mem && !task_in_mem_cgroup(p, mem))
    continue;
    --
    1.6.5.2




    \
     
     \ /
      Last update: 2010-06-03 07:53    [W:0.032 / U:0.092 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site