[lkml]   [2010]   [Jun]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH] oom: Make coredump interruptible
    On 06/02, Oleg Nesterov wrote:
    > On 06/02, Roland McGrath wrote:
    > >
    > > > when select_bad_process() finds the task P to kill it can participate
    > > > in the core dump (sleep in exit_mm), but we should somehow inform the
    > > > thread which actually dumps the core: P->mm->core_state->dumper.
    > >
    > > Perhaps it should simply do that: if you would choose P to oom-kill, and
    > > P->mm->core_state!=NULL, then choose P->mm->core_state->dumper instead.
    > ... to set TIF_MEMDIE which should be checked in elf_core_dump().
    > Probably yes.

    Well, nothing can protect mm->core_state, the dumper owns it. Of course
    we can add the locking, but this is not nice.

    And again, perhaps MMF_OOMKILLED can be useful anyway.

    So, I think this would be the most quick/simple fix for now.


     \ /
      Last update: 2010-06-03 16:09    [W:0.019 / U:22.732 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site