lkml.org 
[lkml]   [2010]   [Jun]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
DateThu, 3 Jun 2010 12:32:25 +0100
FromAlan Cox <>
SubjectRe: [PATCH] usb-serial/ftdi_sio: fix DTR/RTS line modes
On Thu,  3 Jun 2010 13:55:02 +0200
Daniel Mack <daniel@caiaq.de> wrote:

> Call set_mctrl() and clear_mctrl() according to the flow control mode
> selected. This makes serial communication for FT232 connected devices
> work when CRTSCTS is not set.
>
> This fixes a regression introduced by 4175f3e31 ("tty_port: If we are
> opened non blocking we still need to raise the carrier"). This patch
> calls the low-level driver's dtr_rts() function which consequently
> sets TIOCM_DTR | TIOCM_RTS. A later call to set_termios() without
> CRTSCTS in cflags, however, does not reset these bits, and so data is
> not actually sent out on the serial wire.

If you've got hardware the other end expecting RTS/CTS signals you
really ought to set CRTSCTS. However you patch makes complete sense in
terms of which way it is best to end up.


\
 
 \ /
  Last update: 2010-06-03 14:21    [from the cache]
©2003-2010