lkml.org 
[lkml]   [2010]   [Jun]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] usb-serial/ftdi_sio: fix DTR/RTS line modes
On Thu, Jun 03, 2010 at 01:55:02PM +0200, Daniel Mack wrote:
> Call set_mctrl() and clear_mctrl() according to the flow control mode
> selected. This makes serial communication for FT232 connected devices
> work when CRTSCTS is not set.
>
> This fixes a regression introduced by 4175f3e31 ("tty_port: If we are
> opened non blocking we still need to raise the carrier"). This patch
> calls the low-level driver's dtr_rts() function which consequently sets
> TIOCM_DTR | TIOCM_RTS. A later call to set_termios() without CRTSCTS in
> cflags, however, does not reset these bits, and so data is not actually
> sent out on the serial wire.
>
> Signed-off-by: Daniel Mack <daniel@caiaq.de>
> Cc: Greg Kroah-Hartman <gregkh@suse.de>
> Cc: Johan Hovold <jhovold@gmail.com>
> Cc: Alan Cox <alan@linux.intel.com>
> Cc: linux-usb@vger.kernel.org

Oops. I forgot to Cc: stable@kernel.org.
This is in fact broken since 2.6.31-something.




> ---
> drivers/usb/serial/ftdi_sio.c | 4 ++++
> 1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/usb/serial/ftdi_sio.c b/drivers/usb/serial/ftdi_sio.c
> index 050211a..79dd1ae 100644
> --- a/drivers/usb/serial/ftdi_sio.c
> +++ b/drivers/usb/serial/ftdi_sio.c
> @@ -2005,6 +2005,8 @@ static void ftdi_set_termios(struct tty_struct *tty,
> "urb failed to set to rts/cts flow control\n");
> }
>
> + /* raise DTR/RTS */
> + set_mctrl(port, TIOCM_DTR | TIOCM_RTS);
> } else {
> /*
> * Xon/Xoff code
> @@ -2052,6 +2054,8 @@ static void ftdi_set_termios(struct tty_struct *tty,
> }
> }
>
> + /* lower DTR/RTS */
> + clear_mctrl(port, TIOCM_DTR | TIOCM_RTS);
> }
> return;
> }
> --
> 1.7.1
>


\
 
 \ /
  Last update: 2010-06-03 13:59    [W:0.071 / U:0.348 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site