Messages in this thread | | | Date | Tue, 29 Jun 2010 23:23:42 +0530 | From | Srikar Dronamraju <> | Subject | Re: [PATCHv6 2.6.35-rc3-tip 10/12] perf: Dont adjust symbols on name lookup |
| |
> > > > perf: Dont adjust symbols on name lookup > > > > Adjusting symbols is not needed if we are searching by name even > > if the symbols correspond to user space objects. > > Infact if we adjust and search symbols by name, we get incorrect > > results. > > I'll review this, but it would be nice to explain why we get incorrect > results, as we may be just fixing a symptom of some other problem. >
You are right. I removed this patch and still see no change in behaviour. Earlier without this patch, I saw that perf report would show a wrong function name(around 2.6.34-rc5 and I carried it to 2.6.35-tip). However the number of events recorded would correspond to the probed function.
Since I am seeing correct behaviour even without this patch, I will drop this patch in the next posting of the patchset.
-- Thanks Srikar
| |