lkml.org 
[lkml]   [2010]   [Jun]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH] firmware: Update hotplug script, remove sysfs files
    From
    On Sat, Jun 26, 2010 at 3:22 AM, Greg KH <greg@kroah.com> wrote:
    > On Fri, Jun 25, 2010 at 05:55:11PM +0900, Magnus Damm wrote:
    >> From: Magnus Damm <damm@opensource.se>
    >>
    >> Update the in-kernel hotplug example script to work
    >> properly with recent kernels. Without this fix the
    >> script may load the firmware twice - both at "add"
    >> and "remove" time.
    >>
    >> The second load only triggers in the case when multiple
    >> firmware images are used. A good example is the b43
    >> driver which does not work properly without this fix.
    >>
    >> While at it, make sure sysfs files are removed.
    >
    > Hm, the documentation update applied, but this second part didn't.  Care
    > to redo it against the linux-next tree and resend it as a separate
    > patch?  I've split this up and applied the documentation part now, so
    > you don't have to redo that.

    Thanks a lot for splitting up the patch. I don't mind redoing the
    second part of the patch, but I'm not sure if it's actually needed to
    prevent memory leaks. This piece of code serves as an example:

    +error_unreg2:
    + sysfs_remove_bin_file(&f_dev->kobj, &fw_priv->attr_data);
    error_unreg:
    device_unregister(f_dev);

    Perhaps device_unregister() call above already removes the kobj which
    makes the added sysfs_remove_bin_file() unnecessary?

    Cheers,

    / magnus
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2010-06-28 08:19    [W:0.020 / U:122.592 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site