[lkml]   [2010]   [Jun]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH 1/5]security:key.c Fix warning: variable 'key' set but not used
    On 06/28/2010 05:38 AM, David Howells wrote:
    > Justin P. Mattock<> wrote:
    >> In this case the safest approach(in my mind) would be to just
    >> mark the integer __unused. Keep in mind though Im not certain
    >> if this is the right place for this value i.e. will this effect
    >> *instkey or not(please check).
    > This is the wrong approach. Either the variable should be got rid of, or it
    > should be used to replace all the other calls to key_ref_to_ptr() in
    > keyctl_describe_key().
    > David

    I see your patch you sent for this.. vary nice!


    Justin P. Mattock

     \ /
      Last update: 2010-06-28 19:51    [W:0.028 / U:18.520 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site