lkml.org 
[lkml]   [2010]   [Jun]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 1/5]security:key.c Fix warning: variable 'key' set but not used
Date
Justin P. Mattock <justinmattock@gmail.com> wrote:

> In this case the safest approach(in my mind) would be to just
> mark the integer __unused. Keep in mind though Im not certain
> if this is the right place for this value i.e. will this effect
> *instkey or not(please check).

This is the wrong approach. Either the variable should be got rid of, or it
should be used to replace all the other calls to key_ref_to_ptr() in
keyctl_describe_key().

David


\
 
 \ /
  Last update: 2010-06-28 14:41    [from the cache]
©2003-2011 Jasper Spaans