[lkml]   [2010]   [Jun]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH 2/2] block: defer the use of inline biovecs for discard requests
    On Sat, Jun 26, 2010 at 03:56:51PM -0400, Mike Snitzer wrote:
    > Don't alloc discard bio with a biovec in blkdev_issue_discard. Doing so
    > means bio_has_data() will not be true until the SCSI layer adds the
    > payload to the discard request via blk_add_request_payload.
    > bio_{enable,disable}_inline_vecs are not expected to be widely used so
    > they were exported using EXPORT_SYMBOL_GPL.

    Why do we need them exported at all? Also some comments on these
    functions would be useful.

    Otherwise it looks good to me.

     \ /
      Last update: 2010-06-27 11:43    [W:0.018 / U:12.092 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site