Messages in this thread | | | Date | Sun, 27 Jun 2010 11:39:55 +0200 | From | Christoph Hellwig <> | Subject | Re: [PATCH 2/2] block: defer the use of inline biovecs for discard requests |
| |
On Sat, Jun 26, 2010 at 03:56:51PM -0400, Mike Snitzer wrote: > Don't alloc discard bio with a biovec in blkdev_issue_discard. Doing so > means bio_has_data() will not be true until the SCSI layer adds the > payload to the discard request via blk_add_request_payload. > > bio_{enable,disable}_inline_vecs are not expected to be widely used so > they were exported using EXPORT_SYMBOL_GPL.
Why do we need them exported at all? Also some comments on these functions would be useful.
Otherwise it looks good to me.
| |