Messages in this thread | | | Date | Mon, 28 Jun 2010 09:25:37 +0900 | From | Koki Sanagi <> | Subject | Re: [RFC PATCH v2 4/5] skb: add tracepoints to freeing skb |
| |
(2010/06/26 5:05), Eric Dumazet wrote: > Le vendredi 25 juin 2010 à 16:12 +0900, Koki Sanagi a écrit : > >>> You might add a trace point to skb_free_datagram_locked() too, since it >>> contains an inlined consume_skb() >>> >> >> I think it is contrary. > > I think you are _very_ wrong. > >> skb_free_datagram_locked() contains consume_skb(), so tracepoint isn't needed. >> Because skb_free_datagram_locked() can be traced by trace_consume_skb(). >> >> >> > > Koki, it would be good if you worked on net-next-2.6, so that my comment > applies.
Yes, I am very wrong... I saw skb_free_datagram_locked() at linux-2.6.34. It would be good to add tracepoint to it.
> Also, not sending this kind of patches on netdev is not going to help > very much. > > Who is supposed to review them on lkml and Ack them ? > > Nobody. > > Please build your future network related patches against net-next-2.6, > and send them to nedev and David Miller, the official network > maintainer, as stated in MAINTAINERS file. > > NETWORKING [GENERAL] > M: "David S. Miller" <davem@davemloft.net> > L: netdev@vger.kernel.org > W: http://www.linuxfoundation.org/en/Net > W: http://patchwork.ozlabs.org/project/netdev/list/ > T: git git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-2.6.git > T: git git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next-2.6.git > S: Maintained > F: net/ > F: include/net/ > F: include/linux/in.h > F: include/linux/net.h > F: include/linux/netdevice.h
Yes, my submitting this time has many improper things(address, format and description...). I'll check and modify them next time.
Thanks, Koki Sanagi. > > > -- > To unsubscribe from this list: send the line "unsubscribe netdev" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > >
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |