lkml.org 
[lkml]   [2010]   [Jun]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 3/4] hwmon: Update sysfs-interface to include new attributes
Hi Guenter,

On Thu, 24 Jun 2010 15:01:00 -0700, Guenter Roeck wrote:
> Added _lcrit and _crit to voltage attributes.
> Added _lcrit to temperature attributes.
>
> Signed-off-by: Guenter Roeck <guenter.roeck@ericsson.com>
> ---
> Documentation/hwmon/sysfs-interface | 21 ++++++++++++++++++++-
> 1 files changed, 20 insertions(+), 1 deletions(-)
>
> diff --git a/Documentation/hwmon/sysfs-interface b/Documentation/hwmon/sysfs-interface
> index d4e2917..7f60c0d 100644
> --- a/Documentation/hwmon/sysfs-interface
> +++ b/Documentation/hwmon/sysfs-interface
> @@ -107,10 +107,24 @@ in[0-*]_min Voltage min value.
> Unit: millivolt
> RW
>
> +in[0-*]_lcrit Voltage critical min value.
> + Unit: millivolt
> + RW
> + If voltage drops to or below this limit, the system may
> + take drastic action such as power down or reset. At the very
> + least, it should report a fault.
> +
> in[0-*]_max Voltage max value.
> Unit: millivolt
> RW
>
> +in[0-*]_crit Voltage critical max value.
> + Unit: millivolt
> + RW
> + If voltage reaches or exceeds this limit, the system may
> + take drastic action such as power down or reset. At the very
> + least, it should report a fault.
> +
> in[0-*]_input Voltage input value.
> Unit: millivolt
> RO
> @@ -284,11 +298,16 @@ temp[1-*]_input Temperature input value.
> Unit: millidegree Celsius
> RO
>
> -temp[1-*]_crit Temperature critical value, typically greater than
> +temp[1-*]_crit Temperature critical max value, typically greater than
> corresponding temp_max values.
> Unit: millidegree Celsius
> RW
>
> +temp[1-*]_lcrit Temperature critical min value, typically lower than
> + corresponding temp_min values.
> + Unit: millidegree Celsius
> + RW
> +

I'd rather have you insert that one _after_ temp[1-*]_crit_hyst, as
temp[1-*]_crit_hyst is rightly related to temp[1-*]_crit.

> temp[1-*]_crit_hyst
> Temperature hysteresis value for critical limit.
> Unit: millidegree Celsius

Other than this minor issue, which I have addresses myself, this patch
looks very good to me and I've applied it.

Thanks,
--
Jean Delvare


\
 
 \ /
  Last update: 2010-06-25 10:09    [W:0.094 / U:1.376 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site