lkml.org 
[lkml]   [2010]   [Jun]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2] block: Don't count_vm_events for discard bio in submit_bio.
    On 2010-06-24 02:28, Tao Ma wrote:
    > Hi Andrew,
    >> Yes, that's a buglet.
    >>
    >> Note that Christoph's "[PATCH, RFC] block: don't allocate a payload for
    >> discard request" will fix it in a better way. That patch is in
    >> linux-next now, but I expect it will be taken out again (quickly,
    >> please) because Mike has found a number of problems with it.
    > ok, I haven't noticed that. thanks for the info.
    >>
    >> Your patch looks like a decent temporary fix for mainline, and a
    >> permanent one for -stable.
    > I am sorry, but I made a mistake. BIO_RW_DISCARD is a enum for bit offset.
    > So the right check should be rw & (1 << BIO_RW_DISCARD).
    > I have regenerated the patch. Sorry for the inconvenience.

    Thanks, this one looks good. Applied.

    --
    Jens Axboe



    \
     
     \ /
      Last update: 2010-06-24 08:17    [W:0.046 / U:59.944 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site