Messages in this thread | | | Date | Fri, 25 Jun 2010 01:53:49 +1000 | From | Nick Piggin <> | Subject | Re: [patch 14/52] fs: dcache scale subdirs |
| |
On Thu, Jun 24, 2010 at 11:50:17AM +0200, Andi Kleen wrote: > npiggin@suse.de writes: > > > Protect d_subdirs and d_child with d_lock, except in filesystems that aren't > > using dcache_lock for these anyway (eg. using i_mutex). > > Different locking for different file systems seems a bit confusing. > Could the be unified?
Yes well it is a bit misleading. It should always be modified under spinlocks, but some filesystems are using i_mutex for read access, which should be fine (and not require knowledge of any other code).
| |