lkml.org 
[lkml]   [2010]   [Jun]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 5/6 V2] mfd/stmpexxx: fix stmpe811 enable hook
    On Thu, Jun 24, 2010 at 06:05:42PM +0530, Rabin VINCENT wrote:
    > On Thu, Jun 24, 2010 at 14:27:46 +0200, Luotao Fu wrote:
    > > diff --git a/drivers/mfd/stmpe-devices.c b/drivers/mfd/stmpe-devices.c
    > > index 3e21c26..ded9dcb 100644
    > > --- a/drivers/mfd/stmpe-devices.c
    > > +++ b/drivers/mfd/stmpe-devices.c
    > > @@ -117,8 +117,8 @@ static int stmpe811_enable(struct stmpe *stmpe, unsigned int blocks,
    > > if (blocks & STMPE_BLOCK_ADC)
    > > mask |= STMPE811_SYS_CTRL2_ADC_OFF;
    > >
    > > - if (blocks & STMPE_BLOCK_KEYPAD)
    > > - mask |= STMPE811_SYS_CTRL2_TSC_OFF;
    > > + if (blocks & STMPE_BLOCK_TOUCHSCREEN)
    > > + mask |= STMPE811_SYS_CTRL2_ADC_OFF;
    > >
    >
    > You shouldn't be changing TSC_OFF to ADC_OFF, since you're making this
    > for the touchscreen.
    >

    doh! I need more coffee. This is truly embarassing. :-) Proper fix in
    following.

    cheers
    Luotao Fu

    --
    Pengutronix e.K. | Dipl.-Ing. Luotao Fu |
    Industrial Linux Solutions | http://www.pengutronix.de/ |
    Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
    Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |[unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2010-06-24 14:49    [W:7.623 / U:0.016 seconds]
    ©2003-2014 Jasper Spaans. hosted at Digital Ocean