Messages in this thread | | | Subject | Re: [PATCH] ASoC: DaVinci: Added support for stereo I2S | From | Mark Brown <> | Date | Thu, 24 Jun 2010 00:24:16 +0100 |
| |
On 23 Jun 2010, at 15:33, Raffaele Recalcati wrote:
> From: Raffaele Recalcati <raffaele.recalcati@bticino.it> > > Added audio playback support with [frame sync master - clock master] mode > and with [frame sync master - clock slave]. > Clock slave can be important when the external codec need system clock > and bit clock synchronized. > In the clock master case there is a FIXME message in the source code, because we > (Davide and myself) have guessed a frequency of 122000000 that seems the base > to be divided. > This patch has been developed against the > http://git.kernel.org/pub/scm/linux/kernel/git/khilman/linux-davinci.git > git tree and has been tested on bmx board (similar to dm365 evm, but using > uda1345 as external audio codec). > > Signed-off-by: Raffaele Recalcati <raffaele.recalcati@bticino.it> > Signed-off-by: Davide Bonfanti <davide.bonfanti@bticino.it>
I'd pretty much echo what Liam said - I'm not 100% sure from your description what the patch is supposed to do and the code isn't particularly clear either. It *looks* like you're trying to add a new clock source, but from the description this appears to be an externally visible clock which makes it very unclear why you have to guess the frequency.
| |