lkml.org 
[lkml]   [2010]   [Jun]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 11/11] staging: ti dspbridge: enable driver building
On Wed, Jun 23, 2010 at 04:14:00PM +0300, Ohad Ben-Cohen wrote:
> From: Omar Ramirez Luna <omar.ramirez@ti.com>
>
> Add Kconfig + Makefile for TI's DSP Bridge driver
> and expose it to the staging menu.
>
> Signed-off-by: Omar Ramirez Luna <omar.ramirez@ti.com>
> Signed-off-by: Kanigeri, Hari <h-kanigeri2@ti.com>
> Signed-off-by: Ameya Palande <ameya.palande@nokia.com>
> Signed-off-by: Guzman Lugo, Fernando <fernando.lugo@ti.com>
> Signed-off-by: Hebbar, Shivananda <x0hebbar@ti.com>
> Signed-off-by: Ramos Falcon, Ernesto <ernesto@ti.com>
> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
> Signed-off-by: Anna, Suman <s-anna@ti.com>
> Signed-off-by: Gupta, Ramesh <grgupta@ti.com>
> Signed-off-by: Gomez Castellanos, Ivan <ivan.gomez@ti.com>
> Signed-off-by: Andy Shevchenko <ext-andriy.shevchenko@nokia.com>
> Signed-off-by: Armando Uribe De Leon <x0095078@ti.com>
> Signed-off-by: Deepak Chitriki <deepak.chitriki@ti.com>
> Signed-off-by: Menon, Nishanth <nm@ti.com>
> Signed-off-by: Phil Carmody <ext-phil.2.carmody@nokia.com>
> Signed-off-by: Ohad Ben-Cohen <ohad@wizery.com>
> ---
> drivers/staging/Kconfig | 2 +
> drivers/staging/Makefile | 1 +
> drivers/staging/tidspbridge/Kconfig | 88 ++++++++++++++++++++++++++++++++++
> drivers/staging/tidspbridge/Makefile | 34 +++++++++++++
> 4 files changed, 125 insertions(+), 0 deletions(-)
> create mode 100644 drivers/staging/tidspbridge/Kconfig
> create mode 100644 drivers/staging/tidspbridge/Makefile
>
>
> diff --git a/drivers/staging/Kconfig b/drivers/staging/Kconfig
> index 3de4bca..c9e8215 100644
> --- a/drivers/staging/Kconfig
> +++ b/drivers/staging/Kconfig
> @@ -153,5 +153,9 @@ source "drivers/staging/easycap/Kconfig"
>
> source "drivers/staging/solo6x10/Kconfig"
>
> +source "drivers/staging/tidspbridge/Kconfig"
> +
> +source "drivers/staging/tidspbridge/Kconfig"
> +
> endif # !STAGING_EXCLUDE_BUILD
> endif # STAGING
> diff --git a/drivers/staging/Makefile b/drivers/staging/Makefile
> index b28d820..952b64e 100644
> --- a/drivers/staging/Makefile
> +++ b/drivers/staging/Makefile
> @@ -57,3 +57,4 @@ obj-$(CONFIG_TOUCHSCREEN_MRSTOUCH) += mrst-touchscreen/
> obj-$(CONFIG_MSM_STAGING) += msm/
> obj-$(CONFIG_EASYCAP) += easycap/
> obj-$(CONFIG_SOLO6X10) += solo6x10/
> +obj-$(CONFIG_TIDSPBRIDGE) += tidspbridge/
> diff --git a/drivers/staging/tidspbridge/Kconfig b/drivers/staging/tidspbridge/Kconfig
> new file mode 100644
> index 0000000..37fa2b1
> --- /dev/null
> +++ b/drivers/staging/tidspbridge/Kconfig
> @@ -0,0 +1,88 @@
> +#
> +# DSP Bridge Driver Support
> +#
> +
> +menuconfig TIDSPBRIDGE
> + tristate "DSP Bridge driver"
> + default n

The default is always 'n' so you don't need this.

Also, this enables the driver to be built on x86, which fails horribly,
and I don't think is what you really want to have happen :)

So I need some more Kconfig changes here, care to redo just this one
patch? I've applied all the others and they will show up in linux-next
tomorrow.

thanks,

greg k-h


\
 
 \ /
  Last update: 2010-06-24 00:47    [W:0.105 / U:0.116 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site