Messages in this thread | | | From | David Howells <> | Subject | Re: [RFC][PATCH 03/10] cifs: register CIFS for caching | Date | Wed, 23 Jun 2010 17:51:17 +0100 |
| |
Suresh Jayaraman <sjayaraman@suse.de> wrote:
> + rc = cifs_fscache_register(); > + if (rc) > + goto out; > + > rc = cifs_init_inodecache(); > if (rc) > goto out_clean_proc; > @@ -949,8 +954,10 @@ init_cifs(void) > cifs_destroy_mids(); > out_destroy_inodecache: > cifs_destroy_inodecache(); > + cifs_fscache_unregister(); > out_clean_proc:
This is incorrect. You need to call cifs_fscache_unregister() if cifs_init_inodecache() fails.
David
| |