Messages in this thread | | | Date | Wed, 23 Jun 2010 05:08:12 +0200 | From | Frederic Weisbecker <> | Subject | Re: [PATCH] perf: Fix argument of perf_arch_fetch_caller_regs |
| |
On Wed, Jun 23, 2010 at 09:17:53AM +0900, Nobuhiro Iwamatsu wrote: > "struct regs" was set to argument of perf_arch_fetch_caller_regs. > "struct pt_regs" is correct. > > Cc: Frederic Weisbecker <fweisbec@gmail.com> > Cc: Paul Mackerras <paulus@samba.org> > Cc: David Miller <davem@davemloft.net> > Cc: Ingo Molnar <mingo@elte.hu> > Cc: Peter Zijlstra <a.p.zijlstra@chello.nl> > Cc: Arnaldo Carvalho de Melo <acme@redhat.com> > Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
Acked-by: Frederic Weisbecker <fweisbec@gmail.com>
This may fix CONFIG_PERF_EVENTS=y with archs that don't implement perf_arch_fetch_caller_regs, namely ARM, alpha, frv, parisc, s390 and sh.
Ingo, can you please queue this for .36? (it only fixes perf/core)
Thanks.
> --- > include/linux/perf_event.h | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/include/linux/perf_event.h b/include/linux/perf_event.h > index 9073bde..b65736d 100644 > --- a/include/linux/perf_event.h > +++ b/include/linux/perf_event.h > @@ -934,7 +934,7 @@ extern void __perf_sw_event(u32, u64, int, struct > pt_regs *, u64); > > #ifndef perf_arch_fetch_caller_regs > static inline void > -perf_arch_fetch_caller_regs(struct regs *regs, unsigned long ip) { } > +perf_arch_fetch_caller_regs(struct pt_regs *regs, unsigned long ip) { } > #endif > > /* > -- > 1.7.1
| |