lkml.org 
[lkml]   [2010]   [Jun]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH -mm 2/6] rmap: always add new vmas at the end
On Mon, 21 Jun 2010 16:33:49 -0400
Rik van Riel <riel@redhat.com> wrote:

> From: Andrea Arcangeli <aarcange@redhat.com>
> Subject: always add new vmas at the end
>
> Make sure to always add new VMAs at the end of the list. This
> is important so rmap_walk does not miss a VMA that was created
> during the rmap_walk.
>
> The old code got this right most of the time due to luck, but
> was buggy when anon_vma_prepare reused a mergeable anon_vma.
>
> Signed-off-by: Andrea Arcangeli <aarcange@redhat.com>
> Signed-off-by: Rik van Riel <riel@redhat.com>
> ---
>
> diff --git a/mm/rmap.c b/mm/rmap.c
> --- a/mm/rmap.c
> +++ b/mm/rmap.c
> @@ -149,7 +149,7 @@ int anon_vma_prepare(struct vm_area_stru
> avc->anon_vma = anon_vma;
> avc->vma = vma;
> list_add(&avc->same_vma, &vma->anon_vma_chain);
> - list_add(&avc->same_anon_vma, &anon_vma->head);
> + list_add_tail(&avc->same_anon_vma, &anon_vma->head);
> allocated = NULL;
> avc = NULL;
> }

Should this go into 2.6.35?


\
 
 \ /
  Last update: 2010-06-22 23:11    [W:0.084 / U:0.096 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site