lkml.org 
[lkml]   [2010]   [Jun]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] kbuild: Clean up and speed up the localversion logic
    On 22.6.2010 12:44, Nico Schottelius wrote:
    > Michal Marek [Thu, Jun 17, 2010 at 03:40:38PM +0200]:
    >> -cd "${1:-.}" || usage
    >> +scm_only=false
    >> +srctree=.
    >> +if test "$1" = "--scm-only"; then
    >> + scm_only=true
    >> + shift
    >> +fi
    >> +if test $# -gt 0; then
    >> + srctree=$1
    >
    > You probably want
    >
    > srctree="$1"
    >
    > to catch spaces and co. in the path.

    That's the same, the value in variable assignment is not subject to word
    splitting.


    > Otherwise I just had a quick view over it, but seems to look good.

    Thanks!

    /me is now wondering if it's ok to push this for 2.6.35. At least, there
    were no bugreports from linux-next users so far.

    Michal


    \
     
     \ /
      Last update: 2010-06-22 13:17    [W:0.020 / U:91.332 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site