Messages in this thread | | | From | KOSAKI Motohiro <> | Subject | Re: [PATCH 4/9] oom: oom_kill_process() need to check p is unkillable | Date | Mon, 21 Jun 2010 20:45:45 +0900 (JST) |
| |
> On Thu, 17 Jun 2010, KOSAKI Motohiro wrote: > > > When oom_kill_allocating_task is enabled, an argument task of > > oom_kill_process is not selected by select_bad_process(), It's > > just out_of_memory() caller task. It mean the task can be > > unkillable. check it first. > > > > This should be unnecessary if oom_kill_process() appropriately returns > non-zero when it cannot kill a task. What problem are you addressing with > this fix?
oom_kill_process() only check its children are unkillable, not its own. To add check oom_kill_process() also solve the issue. as my previous patch does. but Minchan pointed out it's unnecessary. because when !oom_kill_allocating_task case, we have the same check in select_bad_process().
| |