lkml.org 
[lkml]   [2010]   [Jun]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH 4/9] oom: oom_kill_process() need to check p is unkillable
    Date
    > On Thu, 17 Jun 2010, KOSAKI Motohiro wrote:
    >
    > > When oom_kill_allocating_task is enabled, an argument task of
    > > oom_kill_process is not selected by select_bad_process(), It's
    > > just out_of_memory() caller task. It mean the task can be
    > > unkillable. check it first.
    > >
    >
    > This should be unnecessary if oom_kill_process() appropriately returns
    > non-zero when it cannot kill a task. What problem are you addressing with
    > this fix?

    oom_kill_process() only check its children are unkillable, not its own.
    To add check oom_kill_process() also solve the issue. as my previous patch does.
    but Minchan pointed out it's unnecessary. because when !oom_kill_allocating_task
    case, we have the same check in select_bad_process().





    \
     
     \ /
      Last update: 2010-06-21 13:47    [W:2.302 / U:0.128 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site