Messages in this thread | | | Date | Wed, 2 Jun 2010 10:38:38 +0200 | From | "Roedel, Joerg" <> | Subject | Re: [PATCH 6/17] arch/x86/kernel: Add missing spin_unlock |
| |
Hi Andrew,
On Tue, Jun 01, 2010 at 05:15:29PM -0400, Andrew Morton wrote: > The reason why these bugs occur is that we sprinkle multiple `return' > statements inside the middle of non-trivial functions. People miss > some or fail to modify some when later changing locking rules and we > gain bugs (or, similarly, resource leaks).
Right. I changed that in Julia's patch too before merging it into my tree. It is already in -tip. See http://git.kernel.org/tip/84fe6c19e4a598e8071e3bd1b2c923454eae1268
Joerg
| |