Messages in this thread | | | From | Roland McGrath <> | Subject | Re: [PATCH] oom: Make coredump interruptible | Date | Wed, 2 Jun 2010 11:58:12 -0700 (PDT) |
| |
> Because it is per-thread.
I see.
> when select_bad_process() finds the task P to kill it can participate > in the core dump (sleep in exit_mm), but we should somehow inform the > thread which actually dumps the core: P->mm->core_state->dumper.
Perhaps it should simply do that: if you would choose P to oom-kill, and P->mm->core_state!=NULL, then choose P->mm->core_state->dumper instead.
> Well, we can use TIF_MEMDIE if we chose the right thread, I think. > But perhaps mm->flags |= MMF_OOM is better, it can have other user. > I dunno.
This is all the quick hack before get around to just making core dumping fully-interruptible, no? So we should go with whatever is the simplest change now.
Perhaps this belongs in another thread as you suggested. But I wonder what we might get just from s/TASK_UNINTERRUPTIBLE/TASK_KILLABLE/ in exit_mm.
Thanks, Roland
| |