Messages in this thread |  | | | From | Rusty Russell <> | | Subject | Re: [PATCH 2/2] module: fix bne2 "gave up waiting for init of module libcrc32c" | | Date | Wed, 2 Jun 2010 23:36:51 +0930 |
| |
On Wed, 2 Jun 2010 04:51:46 pm Linus Torvalds wrote: > > On Wed, 2 Jun 2010, Rusty Russell wrote: > > > > Moved all the sysfs-exposing stuff to the end just after we put in the > > list (and thus to after the find check). > > Yeah, makes more sense that way. No reason to expose anything to sysfs > early. And splitting it into two patches makes it easier to follow than > the patch I posted. Ack.
Found another locking issue: the code which verifies we don't export over an existing symbol needs to be atomic wrt. adding us to the list.
This will be in tomorrow's linux-next.
And load_module is down to 259 lines. The label chain at the end is no shorter tho :( I'll leave those cleanups until next merge window.
The following changes since commit aef4b9aaae1decc775778903922bd0075cce7a88: Linus Torvalds (1): Merge branch 'next' of git://git.kernel.org/.../benh/powerpc
are available in the git repository at:
ssh://master.kernel.org/pub/scm/linux/kernel/git/rusty/linux-2.6 modules
Eric Dumazet (1): module: module_unload_init() cleanup
Linus Torvalds (4): module: Make the 'usage' lists be two-way module: move find_module check to end module: refactor load_module module: refactor load_module part 2
Rusty Russell (9): module: fix kdb's illicit use of struct module_use. module: move sysfs exposure to end of load_module module: Make module sysfs functions private. module: make locking more fine-grained. module: verify_export_symbols under the lock module: fix bne2 "gave up waiting for init of module libcrc32c" module: refactor load_module part 3 module: refactor load_module part 4 module: refactor load_module part 5
include/linux/module.h | 44 +-- kernel/debug/kdb/kdb_main.c | 12 +- kernel/module.c | 899 +++++++++++++++++++++++++------------------ 3 files changed, 547 insertions(+), 408 deletions(-)
|  |