lkml.org 
[lkml]   [2010]   [Jun]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH V2] misc : ROHM BH1780GLI Ambient light sensor Driver
Date
----- Original Message ----- 
From: "Andrew Morton" <akpm@linux-foundation.org>
To: "Jonathan Cameron" <kernel@jic23.retrosnub.co.uk>
Cc: "Hemanth V" <hemanthv@ti.com>; <linux-kernel@vger.kernel.org>;
<linux-omap@vger.kernel.org>; "Daniel Mack" <daniel@caiaq.de>; "Jonathan
Cameron" <jic23@cam.ac.uk>; "Wolfram Sang" <w.sang@pengutronix.de>
Sent: Wednesday, June 02, 2010 2:24 AM
Subject: Re: [PATCH V2] misc : ROHM BH1780GLI Ambient light sensor Driver


> On Tue, 01 Jun 2010 21:39:10 +0100
> Jonathan Cameron <kernel@jic23.retrosnub.co.uk> wrote:
>
>> >
>> > It would be most useful if the changelog were to fully describe the
>> > proposed kernel<->userspace interface. That's the most important part
>> > of the driver, because it's the only part we can never change.
>> >
>> > There is a desultory effort to maintain sysfs API descriptions under
>> > Documentation/ABI/. I'd have thought that it would be appropriate to
>> > document this driver's ABI in there.
>> Agreed, but we get back to the debate of what we should standardise on.
>
> I'd suggest standardising on one of the existing drivers. That way we
> have two compliant drivers and only need to change (n-2) others. If we
> pick some new standard then we need to change (n) drivers.
>

Currently this driver follows the same sysfs convention as supported
by isl29003.c in drivers/misc.



\
 
 \ /
  Last update: 2010-06-02 11:03    [W:0.067 / U:0.424 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site