lkml.org 
[lkml]   [2010]   [Jun]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/3] writeback: Creating /sys/kernel/mm/writeback/writeback
    On Fri, Jun 18, 2010 at 05:30:13PM -0700, Michael Rubin wrote:
    > Adding the /sys/kernel/mm/writeback/writeback file. It contains data
    > to help developers and applications gain visibility into writeback
    > behaviour.
    >
    > # cat /sys/kernel/mm/writeback/writeback
    > pages_dirtied: 3747
    > pages_cleaned: 3618
    > dirty_threshold: 816673
    > bg_threshold: 408336

    I'm fine with exposting this. but the interface is rather awkward.
    These kinds of multiple value per file interface require addition
    parsing and are a pain to extend. Please do something like

    /proc/sys/vm/writeback/

    pages_dirtied
    pages_cleaned
    dirty_threshold
    background_threshold

    where you can just read the value from the file.

    > diff --git a/fs/nilfs2/segment.c b/fs/nilfs2/segment.c
    > index c920164..84b0181 100644
    > --- a/fs/nilfs2/segment.c
    > +++ b/fs/nilfs2/segment.c
    > @@ -1598,8 +1598,10 @@ nilfs_copy_replace_page_buffers(struct page *page, struct list_head *out)
    > } while (bh = bh->b_this_page, bh2 = bh2->b_this_page, bh != head);
    > kunmap_atomic(kaddr, KM_USER0);
    >
    > - if (!TestSetPageWriteback(clone_page))
    > + if (!TestSetPageWriteback(clone_page)) {
    > inc_zone_page_state(clone_page, NR_WRITEBACK);
    > + inc_zone_page_state(clone_page, NR_PAGES_ENTERED_WRITEBACK);
    > + }
    > unlock_page(clone_page);

    I'm not very happy about having this opencoded in a filesystem.



    \
     
     \ /
      Last update: 2010-06-19 12:47    [W:0.020 / U:34.104 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site