Messages in this thread | | | From | John Ogness <> | Subject | Re: [PATCH 4/5] mtd: mxc_nand fixups | Date | Sat, 19 Jun 2010 22:25:25 +0200 |
| |
On 2010-06-18, Sascha Hauer <s.hauer@pengutronix.de> wrote: >> This patch reverts the driver to enabling/disabling the NFC interrupt >> mask rather than enabling/disabling the system interrupt. This cleans >> up the driver so that it doesn't rely on interrupts being disabled >> within the interrupt handler. > > This behaviour was introduced in > a47bfd2eb66837653dc3b42541dfe4283dd41251 mxc_nand: support i.MX21 > > I guess this won't work on i.MX21.
I just downloaded the i.MX21 reference manual and its NFC interrupts can also be masked with INT_MASK (bit 4) of NFC_Flash_Config1 (0xdf003e1a).
IMHO we should revert the driver to masking the NFC interrupts. The current linux-next version with nosync irq disabling within the interrupt handler is a bit silly. Especially since the interrupt handler does nothing except signal a wait queue.
John Ogness
| |