Messages in this thread | | | Date | Sat, 19 Jun 2010 21:19:09 +0200 | From | Oleg Nesterov <> | Subject | Re: while_each_thread() under rcu_read_lock() is broken? |
| |
On 06/18, Mandeep Baines wrote: > > On Fri, Jun 18, 2010 at 12:34 PM, Oleg Nesterov <oleg@redhat.com> wrote: > > > > > > I _really_ hope I missed something, will recheck tomorrow with the fresh > > head. Still I'd like to share my concerns... > > Yep. You're right. Not sure what I was thinking. This is only case > where do_each_thread > is protected by an rcu_read_lock. All others, correctly use read_lock.
No, no. while_each_thread() is supposed to be rcu-safe, we should fix it. It has many rcu_read_lock() users.
The patch which fixes rcu_lock_break() is orthogonal to this problem.
Oleg.
| |