Messages in this thread | | | Date | Sat, 19 Jun 2010 21:08:40 +0200 | From | Oleg Nesterov <> | Subject | [PATCH 0/4] pid_ns_prepare_proc/unshare cleanups |
| |
On 06/18, Oleg Nesterov wrote: > > I only try to discuss the idea to break the circular reference.
I don't know what I have missed, but this looks really right to me. Besides, we have yet another problem: proc_flush_task()->mntput() is just wrong. Consider the multithreaded execing init.
I am going to simplify, test, and send the fix which moves mntput() into free_pid_ns() paths.
But first of all I think we should cleanup the pid_ns_prepare_proc() logic. Imho, this code is really ugly. Please see the patches.
The last one, 4/4, is orthogonal to other changes.
Oleg.
| |