lkml.org 
[lkml]   [2010]   [Jun]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] Slabinfo: Fix display format
    On 6/17/10 5:10 PM, wzt wzt wrote:
    > On Thu, Jun 17, 2010 at 9:45 PM, Christoph Lameter
    > <cl@linux-foundation.org> wrote:
    >> On Thu, 17 Jun 2010, wzt.wzt@gmail.com wrote:
    >
    >> This one may break user space tools that have assumptions about the length
    >> of the field. Or do tools not make that assumption?
    >
    > User space tools usually use sscanf() to extract this field like:
    > sscanf(buff, "%s %d", name,&num);
    > If %-27s can break some user space tools that have assumptions about
    > the length of the field, the orig %-17s can also break it.
    > The longest name inotify_event_private_data is 26 bytes in 2.6.34-rc2,
    > the tools still can't extract it.

    NAK. It's an ABI so the risks of this format cleanup outweight the benefits.

    Pekka


    \
     
     \ /
      Last update: 2010-06-18 08:11    [W:0.020 / U:60.272 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site