Messages in this thread | | | Date | Fri, 18 Jun 2010 19:57:26 +0200 | From | Marcin Slusarz <> | Subject | Re: [patch] x86, pat: freeing invalid memtype messages |
| |
On Fri, Jun 18, 2010 at 02:47:45PM +0800, Xiaotian Feng wrote: > On 06/18/2010 12:17 AM, Marcin Slusarz wrote: > > On Thu, Jun 17, 2010 at 03:45:59PM +0200, Dan Carpenter wrote: > >> Commit 20413f27163 "x86, pat: Fix memory leak in free_memtype" added an > >> error message in free_memtype() if rbt_memtype_erase() returns NULL. > >> The problem is that if CONFIG_X86_PAT is enabled, we use a different > >> implimentation of rbt_memtype_erase() that always returns NULL. > >> > >> I've modified rbt_memtype_erase() to return an ERR_PTR() on errors and > >> made free_memtype() check for that instead. > >> > >> Addresses: https://bugzilla.kernel.org/show_bug.cgi?id=16205 > >> > >> Signed-off-by: Dan Carpenter<error27@gmail.com> > > > > This patch is probably ok, but it does not address my bug. > > I have CONFIG_X86_PAT=y, so rbt_memtype_erase does not always return NULL. > > Could you please try boot with kernel parameter "debugpat", and > show me the output of reserve_memtype/free_memtype ? >
reserve_memtype added 0xfed00000-0xfed01000, track uncached-minus, req uncached-minus, ret uncached-minus reserve_memtype added 0xbf780000-0xbf78d000, track uncached-minus, req uncached-minus, ret uncached-minus reserve_memtype added 0xbf79a000-0xbf79d000, track uncached-minus, req uncached-minus, ret uncached-minus reserve_memtype added 0xbf798000-0xbf799000, track uncached-minus, req uncached-minus, ret uncached-minus reserve_memtype added 0xbf780000-0xbf781000, track uncached-minus, req uncached-minus, ret uncached-minus reserve_memtype added 0xbf798000-0xbf799000, track uncached-minus, req uncached-minus, ret uncached-minus reserve_memtype added 0xbf7dc000-0xbf7dd000, track uncached-minus, req uncached-minus, ret uncached-minus reserve_memtype added 0xbf780000-0xbf781000, track uncached-minus, req uncached-minus, ret uncached-minus reserve_memtype added 0xbf798000-0xbf799000, track uncached-minus, req uncached-minus, ret uncached-minus reserve_memtype added 0xbf780000-0xbf781000, track uncached-minus, req uncached-minus, ret uncached-minus reserve_memtype added 0xbf798000-0xbf799000, track uncached-minus, req uncached-minus, ret uncached-minus reserve_memtype added 0xbf78f000-0xbf790000, track uncached-minus, req uncached-minus, ret uncached-minus reserve_memtype added 0xbf78f000-0xbf790000, track uncached-minus, req uncached-minus, ret uncached-minus free_memtype request 0xbf798000-0xbf799000 reserve_memtype added 0xbf798000-0xbf799000, track uncached-minus, req uncached-minus, ret uncached-minus free_memtype request 0xbf798000-0xbf799000 reserve_memtype added 0xbf798000-0xbf799000, track uncached-minus, req uncached-minus, ret uncached-minus free_memtype request 0xbf798000-0xbf799000 reserve_memtype added 0xbf798000-0xbf799000, track uncached-minus, req uncached-minus, ret uncached-minus free_memtype request 0xbf798000-0xbf799000 reserve_memtype added 0xbf799000-0xbf79a000, track uncached-minus, req uncached-minus, ret uncached-minus free_memtype request 0xbf799000-0xbf79a000 reserve_memtype added 0xbf799000-0xbf79a000, track uncached-minus, req uncached-minus, ret uncached-minus swapper:1 freeing invalid memtype bf799000-bf79a000
http://kadu.net/~joi/kernel/2010.06.09/2.6.35-rc3-debugpat.txt
Marcin
| |