Messages in this thread | | | Date | Fri, 18 Jun 2010 13:14:03 +0100 | From | Ralf Baechle <> | Subject | Re: MIPS: return after handling coprocessor 2 exception |
| |
On Fri, Jun 18, 2010 at 02:35:54PM +0400, Gleb O. Raiko wrote:
> >static int default_cu2_call(struct notifier_block *nfb, unsigned long action, > > void *data) > >{ > > ... > > > > return NOTIFY_OK | NOTIFY_STOP; > NOTIFY_STOP implies NOTIFY_OK, so > return NOTIFY_STOP; > shall be enough.
Correct - I was thinking NOTIFY_STOP_MASK.
> >} > > >The notifier list could also be used for example by perf > > Or octeon cop2 handler that just sends NOTIFY_BAD for getting the > same behavior.
Bad karma to return an error for where none happened.
Ralf
| |