lkml.org 
[lkml]   [2010]   [Jun]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 09/12] vmscan: Setup pagevec as late as possible in shrink_page_list()
On Wed, Jun 16, 2010 at 04:48:01PM -0700, Andrew Morton wrote:
> On Mon, 14 Jun 2010 12:17:50 +0100
> Mel Gorman <mel@csn.ul.ie> wrote:
>
> > shrink_page_list() sets up a pagevec to release pages as according as they
> > are free. It uses significant amounts of stack on the pagevec. This
> > patch adds pages to be freed via pagevec to a linked list which is then
> > freed en-masse at the end. This avoids using stack in the main path that
> > potentially calls writepage().
> >
>
> hm, spose so. I cen't see any trivial way to eliminate the local
> pagevec there.
>
> > + if (pagevec_count(&freed_pvec))
> > + __pagevec_free(&freed_pvec);
> > ...
> > - if (pagevec_count(&freed_pvec))
> > - __pagevec_free(&freed_pvec);
>
> That's an open-coded pagevec_free().
>

Fair point, will correct. Thanks

--
Mel Gorman
Part-time Phd Student Linux Technology Center
University of Limerick IBM Dublin Software Lab


\
 
 \ /
  Last update: 2010-06-17 12:49    [W:3.888 / U:0.012 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site