lkml.org 
[lkml]   [2010]   [Jun]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Overview of concurrency managed workqueue
On Thu, 17 Jun 2010 16:25:03 -0700
Joel Becker <Joel.Becker@oracle.com> wrote:

> On Thu, Jun 17, 2010 at 04:14:12PM -0700, Andrew Morton wrote:
> > flush_workqueue() sucks. It's a stupid, accidental,
> > internal-implementation-dependent interface. We should deprecate it
> > and try to get rid of it, migrating to the eminently more sensible
> > flush_work().
> >
> > I guess the first step is to add a dont-do-that checkpatch warning when
> > people try to add new flush_workqueue() calls.
> >
> > 165 instances tree-wide, sigh.
>
> What would the API be for "I want this workqueue emptied before
> I shut this thing down?"

Um, yeah. flush_workqueue() is legitimate. I was thinking of
flush_scheduled_work() - the one which operates on the keventd queue.




\
 
 \ /
  Last update: 2010-06-18 02:01    [from the cache]
©2003-2011 Jasper Spaans