[lkml]   [2010]   [Jun]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH] kbuild: Clean up and speed up the localversion logic
    On Thu, 17 Jun 2010, Michal Marek wrote:

    > Now that we run scripts/setlocalversion during every build, it makes
    > sense to move all the localversion logic there. This cleans up the
    > toplevel Makefile and also makes sure that the script is called only
    > once in 'make prepare' (previously, it would be called every time due to
    > a variable expansion in an ifneq statement). No user-visible change is
    > intended, unless one runs the setlocalversion script directly.
    > Reported-by: Dmitry Torokhov <>
    > Cc: David Rientjes <>
    > Cc: Greg Thelen <>
    > Cc: Nico Schottelius <>
    > Signed-off-by: Michal Marek <>
    > ---
    > I tried to test this in various scenarios, but if anyone of you could give
    > it a try, that would be great. The patch is against 2.6.35-rc3.

    I agree it would be better to move this to scripts/setlocalversion, thanks
    for looking into it. I'll put this into my build cycles and see if it
    causes any issues in my workflow that is known to be good with 2.6.35-rc3.
    Since this is 2.6.36 material, it seems like we have some time.

     \ /
      Last update: 2010-06-18 01:07    [W:0.021 / U:185.712 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site