Messages in this thread |  | | | Date | Thu, 17 Jun 2010 13:15:32 -0700 | | Subject | Re: [PATCH v3 00/10] BKL conversion in tty layer | | From | Tony Luck <> |
| |
> Does the patch below make this go away? We should probably include > the 'misc' branch of my BKL repository in -next to fix this.
That fixes a couple of instances (the tty_open() cases). I still have:
WARNING: at include/linux/tty.h:589 tty_release+0x90/0xbc0() WARNING: at include/linux/tty.h:589 tty_release+0x630/0xbc0() WARNING: at include/linux/tty.h:589 tty_release+0x90/0xbc0() WARNING: at include/linux/tty.h:589 tty_release+0x630/0xbc0() WARNING: at include/linux/tty.h:589 tty_release+0x90/0xbc0() WARNING: at include/linux/tty.h:589 tty_release+0x630/0xbc0()
Stack traces for these all look the same:
Call Trace: [<a000000100015990>] show_stack+0x50/0xa0 [<a00000010090f1f0>] dump_stack+0x30/0x50 [<a00000010008e280>] warn_slowpath_common+0xc0/0x120 [<a00000010008e320>] warn_slowpath_null+0x40/0x60 [<a00000010053d910>] tty_release+0x90/0xbc0 [<a0000001001ab200>] __fput+0x260/0x420 [<a0000001001ab400>] fput+0x40/0x60 [<a00000010053b3b0>] tty_vhangup_locked+0x870/0x8a0 [<a00000010054f3f0>] pty_close+0x350/0x3a0 [<a00000010053ddd0>] tty_release+0x550/0xbc0 [<a0000001001ab200>] __fput+0x260/0x420 [<a0000001001ab400>] fput+0x40/0x60 [<a0000001001a4dc0>] filp_close+0x120/0x140 [<a0000001001a4f90>] sys_close+0x1b0/0x2c0 [<a00000010000b940>] ia64_ret_from_syscall+0x0/0x20 -Tony
|  |