Messages in this thread | | | Date | Thu, 17 Jun 2010 19:31:42 +0200 | From | Borislav Petkov <> | Subject | Re: [PATCH 1/2] perf: Add persistent events |
| |
From: Steven Rostedt <rostedt@goodmis.org> Date: Thu, Jun 17, 2010 at 12:19:57PM -0400
> On Thu, 2010-06-17 at 15:43 +0200, Borislav Petkov wrote: > > > > One of the goals at least I have with pursuing this path is to separate > > > out everything that is not strictly 'perf' into things that can be reused > > > by other tools, like yours. > > > > I'm still splitting perf/util into a more or less generic lib. > > Now, I want to reuse as much code as possible and am parsing > > the "mce:mce_record" tracepoint using parse_events(). However, > > this means that I have to push the not-so-generic perf bits > > like util/parse-events.c into the lib. Which, in turn, pulls in > > util/trace-event* etc. > > Note, I have a separate generic library in trace-cmd that has the > parsing of trace events as its own library now. > > This is the code that started trace-event-parse.c. > > It has evolved quite a bit since then. You can get the code from: > > git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/trace-cmd.git > > The files are parse-events.c and parse-events.h. As well as some > filtering code: parse-filter.c. > > It creates a libparsevent library. > > I've been meaning to update the perf stuff with it, but just have not > had the time. Seems that what you are doing might be a good fit for it.
I see, well, I could take it and merge it into tools/trace-cmd or something and then we all could gradually weed out common code. But I'm open to other suggestions as well.
I mean, it is only natural if we merry perf and ftrace in kernel space to do the same in userspace, right :)
-- Regards/Gruss, Boris.
Advanced Micro Devices GmbH Einsteinring 24, 85609 Dornach General Managers: Alberto Bozzo, Andrew Bowd Registration: Dornach, Gemeinde Aschheim, Landkreis München Registergericht Muenchen, HRB Nr. 43632 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |