[lkml]   [2010]   [Jun]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: bnx2 fails to compile on parisc because of missing get_dma_ops()
    On Thu, 2010-06-17 at 06:30 -0700, Michael Chan wrote: 
    > James Bottomley wrote:
    > > On Thu, 2010-06-17 at 05:54 -0700, Michael Chan wrote:
    > > > This prefetch improves performance noticeably when the driver is
    > > > handling incoming 64-byte packets at a sustained rate.
    > >
    > > So why not do it unconditionally? The worst that can happen
    > > is that you
    > > pull in a stale cache line which will get cleaned in the
    > > dma_sync, thus
    > > slightly degrading performance on incoherent architectures.
    > The original patch was an unconditional prefetch. There was
    > some discussion that it might not be correct if the DMA wasn't
    > sync'ed yet on some archs. If the concensus is that it is ok to
    > do so, that would be the simplest solution.

    It's definitely not "correct" in that it may pull in stale data. But it
    should be harmless in that if it does, the subsequent sync will destroy
    the cache line (even if it actually pulled in correct data) and prevent
    the actual use of the prefetched data being wrong (or indeed being
    prefetched at all).


     \ /
      Last update: 2010-06-17 15:39    [W:0.019 / U:13.972 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site